refactor(match2): ffa match summaries to widget3#7697
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors FFA match summary rendering to Widget3 by migrating many match-summary entrypoints and shared FFA summary widgets away from the legacy Module:Widget/Html/All import and Widget2 class-style widgets.
Changes:
- Switch FFA match summary modules (multiple wikis + commons) from
Module:Widget/Html/AlltoModule:Widget/Html, and update return annotations toRenderable/VNode. - Refactor several shared FFA summary widgets to functional components via
Module:Widget/Component. - Update commons FFA base summary rendering to use Widget3
Html.*nodes consistently.
Reviewed changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lua/wikis/warcraft/MatchSummary/Ffa.lua | Update FFA match summary to use Module:Widget/Html + Widget3 types/casts. |
| lua/wikis/underlords/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/trackmania/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/thefinals/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/tft/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/pubgmobile/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/pubg/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/naraka/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/lab/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/hearthstone/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/halo/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/geoguessr/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/freefire/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/fortnite/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/counterstrike/MatchSummary/Ffa.lua | Same Widget3 HTML import + type/cast adjustments. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/Trophy.lua | Convert Trophy widget to Widget3 functional component. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/TableRowCell.lua | Convert TableRowCell widget to Widget3 functional component + props typing. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/TableRow.lua | Convert TableRow widget to Widget3 functional component. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/TableHeaderCell.lua | Convert TableHeaderCell widget to Widget3 functional component + props typing. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/TableHeader.lua | Convert TableHeader widget to Widget3 functional component (needs scoping fix). |
| lua/wikis/commons/Widget/Match/Summary/Ffa/Table.lua | Convert Table widget to Widget3 functional component. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/Tab.lua | Convert Tab widget to Widget3 functional component. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/RankRange.lua | Convert RankRange widget to Widget3 functional component + interleaving output. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/PointsDistribution.lua | Update widget to use Module:Widget/Html instead of Html/All. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/Mvp.lua | Convert MVP widget to Widget3 functional component. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/MatchInformation.lua | Refactor MatchInformation rendering to Widget3 component style. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/MatchComment.lua | Convert MatchComment widget to Widget3 functional component. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/Header.lua | Convert Header widget to Widget3 functional component. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/GamesSchedule.lua | Refactor GamesSchedule rendering to Widget3 component style. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/GameDetails.lua | Convert GameDetails widget to Widget3 functional component. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/GameCountdown.lua | Convert GameCountdown widget to Widget3 functional component. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/CountdownIcon.lua | Convert CountdownIcon widget to Widget3 functional component. |
| lua/wikis/commons/Widget/Match/Summary/Ffa/ContentItemContainer.lua | Convert ContentItemContainer widget to Widget3 functional component + boolean handling. |
| lua/wikis/commons/Widget/Match/Page/Comment.lua | Adjust return type annotation to VNode. |
| lua/wikis/commons/Widget/GeneralCollapsible/Toggle.lua | Adjust return type annotation to VNode. |
| lua/wikis/commons/MatchSummary/Starcraft/Ffa.lua | Update commons Starcraft FFA match summary to use Module:Widget/Html + Widget3 types/casts. |
| lua/wikis/commons/MatchSummary/Base/Ffa.lua | Switch base FFA summary rendering to Module:Widget/Html and update return annotations. |
| lua/wikis/commons/GameSummary.lua | Adjust match type annotation to use ---@cast. |
| lua/wikis/callofduty/MatchSummary/Ffa.lua | Update FFA match summary to use Module:Widget/Html + Widget3 types/casts. |
| lua/wikis/autochess/MatchSummary/Ffa.lua | Update FFA match summary to use Module:Widget/Html + Widget3 types/casts. |
| lua/wikis/arenafps/MatchSummary/Ffa.lua | Update FFA match summary to use Module:Widget/Html + Widget3 types/casts. |
| lua/wikis/apexlegends/MatchSummary/Ffa.lua | Update FFA match summary to use Module:Widget/Html + Widget3 types/casts. |
| lua/wikis/ageofempires/MatchSummary/Ffa.lua | Update FFA match summary to use Module:Widget/Html + Widget3 types/casts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hjpalpha
approved these changes
Jun 25, 2026
hjpalpha
left a comment
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
skimmed through it on phone
looks reasonable
Rathoz
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How did you test this change?
trivial